Fix capsule-cylinder collision in godot physics #47084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test specific axes before falling back to GJK-EPA algorithm to get more accurate separation axes for common cases, the same way it's done for cylinder-cylinder collision.
This was referenced Mar 17, 2021
akien-mga
approved these changes
Mar 17, 2021
|
Thanks! |
|
Still seems to be a minor issue when you cross one of the axes on the side of the cylinder (z-axis in local coordinates): cylinder-capsule-z-axis.mp4 |
|
@e344fde6bf I'm not able to reproduce this issue with a modified version of your MRP from #47058. Could you please open an issue for this one with a MRP, and also add a MRP for #47094, #47095 and #47096? It would make it easier to track and test by anybody, especially if only some of these issues remain later. |
|
I've uploaded my test world here https://github.com/e344fde6bf/godot-physics-sandbox which should be helpful for testing theses bugs. I'll add a link to it in the issues, and try to get a minimal example latter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test specific axes before falling back to GJK-EPA algorithm to get more accurate separation axes for common cases, the same way it's done for cylinder-cylinder collision.
Fixes issues from #47067 (comment) & #47067 (comment)